Cleanup in cpp files and remove unused custom_proto files for DAQmx and FPGA. #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raghav-NI
requested review from
reckenro,
astarche and
maxxboehme
as code owners
reckenro
approved these changes
Dec 2, 2024
Raghav-NI
deleted the
users/rrawat/cleanup_daqmx_fpga_streaming_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR does the cleanup needed in various files.
Why should this Pull Request be merged?
There were various existing indentation and formatting issues in cpp files which needs to be fixed.
Unused custom_proto files in DAQmx and FPGA should also be removed
What testing has been done?
Able to build and run grpc server and run tests.