Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sideband_port configuration return default if not present. #1135

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Make sideband_port configuration return default if not present. #1135

merged 1 commit into from
Dec 3, 2024

Conversation

amehra-ni
Copy link
Contributor

What does this Pull Request accomplish?

The sideband port was previously a required entry in the configuration file and would throw an exception if the entry was not available. Ideally, the presence of this entry in the file should not be mandatory. This PR fix that.

Why should this Pull Request be merged?

  • Return the default sideband port if the sideband_port entry is unavailable.

What testing has been done?

Able to run the server without the entry in the file.

@amehra-ni amehra-ni requested a review from doshirohan December 3, 2024 06:20
@amehra-ni amehra-ni marked this pull request as ready for review December 3, 2024 06:21
@doshirohan doshirohan merged commit bc1e34b into main Dec 3, 2024
10 checks passed
@doshirohan doshirohan deleted the users/amehra/sideband-port-default branch December 3, 2024 06:38
doshirohan added a commit that referenced this pull request Dec 4, 2024
@doshirohan
Merge remote-tracking branch 'origin/main' into users/indoshir/daq-in…
4e2e824 
…tegration-tests

* origin/main:
  handle null (#1135)
  cleanup (#1133)
  Add codegen support for Daqmx Write apis which have multiple in params. (#1130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doshirohan doshirohan doshirohan approved these changes

@astarche astarche Awaiting requested review from astarche astarche is a code owner

@reckenro reckenro Awaiting requested review from reckenro reckenro is a code owner

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amehra-ni @doshirohan