Allow pascal-case imports and disable consistent-generic-constructors #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found two rules causing new, unwanted violations in the Nimble repo:
@typescript-eslint/consistent-generic-constructors
results in code like this:reporting violations like "The generic type arguments should be specified as part of the constructor type arguments". I had tried to disable this in the prior PR, but was doing so from the wrong config.
@typescript-eslint/naming-convention
now covers imported namespaces (e.g.import * as Foo from '../foo'
), and it defaults to allowing both camel and pascal case. However, because we are configuring the'default'
selector (which matches anything not otherwise specified) to only allow camel case, it was disallowing pascal case for those imported namespaces.