[Do Not Review] Test PR #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avinash2Suresh
requested review from
csjall,
dixonjoel and
bkeryan
as code owners
jayaseelan-james
approved these changes
Sep 25, 2024
|
Recently, I noticed a PR where merging was enabled without the code-owners' approval. To verify, I raised a test PR, but it seems that's not the case here. Therefore, I am closing this PR. |
|
@Avinash2Suresh @jayaseelan-james I think this was a side effect of the https://github.com/CasperWA/push-protected action, which edits the repo's branch protection rules to temporarily unprotect reviews. @dixonjoel noticed this and already restored the settings. I filed #940 about preventing this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
TODO: Include high-level description of the changes in this pull request.
Why should this Pull Request be merged?
TODO: Justify why this contribution should be part of the project.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.