-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DAQmx calibration info properties #473
Add support for DAQmx calibration info properties #473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you have so far looks good to me. I agree with Brad that the other properties should be generated. Also some formatting things that I think the PR will yell at you about. Otherwise you can run ni-python-styleguide
or black
to fix most of them.
35551a8
to
c202241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great once Brad's suggestion is in!
@zhindes @bkeryan Any suggestion to resolve the docs build failure? Based on the error message, the pipeline is running Sphinx v4.5.0 whereas the sphinxcontrib.applehelp extension requires Sphinx v5.0. https://readthedocs.org/projects/nidaqmx-python/builds/23394435/ |
That's fixed in mainline. See #487. I think if you rebase your changes on latest master it will be resolved. I'm more worried about you system tests failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
3aca8b8
to
6a2d14f
Compare
Thanks, rebase my branch to latest master resolves the docs build issue. |
6a2d14f
to
5a52db9
Compare
What does this Pull Request accomplish?
This PR is to add calibration info APIs support.
Work Item: https://dev.azure.com/ni/DevCentral/_workitems/edit/2611013
Why should this Pull Request be merged?
It provides support for calibration info reflection.
What testing has been done?
Regression test on test machine - passing.