-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit test for cfg_time_start_trig #488
Add Unit test for cfg_time_start_trig #488
Conversation
|
That doesn't surprise me, but I'm having trouble finding specific driver code that would do this. If you validate in LV, then that's good. Another thing to validate is use NI I/O Trace to ensure the settings going to the driver from Python are what you expect. |
@zhindes Got my hands on a physical cdaq-9189, yes it is able to set timescale to I/O time. This is the result of IO Trace on a simulated FIeldDAQ device in Labview This is the result of IO Trace on simulated FieldDAQ in python From both it seems that the value being passed into C API is correct (IODevice). Just that simulated devices seem to return HOST instead of IO Device. |
938e8cc
to
468dae5
Compare
75d8693
to
6ba9796
Compare
What does this Pull Request accomplish?
Add unit test coverage for cfg_time_start_trig
Add unit test coverage for new property introduced in #481
Created a new file called test_triggers.py because the existing test_triggers.py seems to use legacy testing environment and I foresee we will be adding a lot of new test coverage for time trigger APIs.
Made fixes to get_trig_attribute_timestamp as we found some missing conversion there.
Updated conftest.py to actually pull the simulated device.
Why should this Pull Request be merged?
Adds unit test coverage
What testing has been done?
All tests passed including the new tests