Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import MAX config when running system tests #489

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Feb 5, 2024

What does this Pull Request accomplish?

Attempting to dynamically import the MAX configuration required for system tests rather than rely on the system image to have done that.

Why should this Pull Request be merged?

Less maintenance cost of the system image.

What testing has been done?

PR build ran the new test_ai_channel.py tests:

  • Reported 50 more tests than before (1200 vs 1150)
  • Downloaded the XML and confirmed those tests ran
  • Log of import step looks correct
Run C:\nidaqmxconfig\targets\win64U\x64\msvc-14.0\release\nidaqmxconfig.exe --eraseconfig --import tests\max_config\nidaqmxMaxConfig.ini
Processed:
   Deleting nidaqmxMultithreadingTester2
   Deleting nidaqmxMultithreadingTester3
   Deleting nidaqmxMultithreadingTester1
   Deleting nidaqmxMultithreadingTester4
   Deleting aoTester
   Deleting bridgeTester
   Deleting tsChassisTester
   Deleting cdaqChassisTester
   aoTester
   AOTesterTask
   AOTesterTask/VoltageOut_0
   AOTesterTask/VoltageOut_1
   AOTesterTask/VoltageOut_2
   bridgeTester
   cdaqChassisTester
   chargeTester
   dmmTester
   double_gain_scale
   dsaTester
   nidaqmxMultithreadingTester1
   nidaqmxMultithreadingTester2
   nidaqmxMultithreadingTester3
   nidaqmxMultithreadingTester4
   no_scaling_scale
   polynomial_scale
   positionTester
   RM-24999_A/bridgeTester/0
   tempTester
   tsChassisTester
   tsPowerTester1
   tsPowerTester2
   tsVoltageTester1
   VoltageTesterChannel
   VoltageTesterChannel2
   VoltageTesterTask
   VoltageTesterTask/Voltage_0
Success

Copy link

github-actions bot commented Feb 5, 2024

Test Results

    30 files  ±0      30 suites  ±0   34m 43s ⏱️ +38s
 1 380 tests ±0   1 200 ✅ + 50    180 💤  -  50  0 ❌ ±0 
21 330 runs  ±0  18 710 ✅ +750  2 620 💤  - 750  0 ❌ ±0 

Results for commit aa141fe. ± Comparison against base commit 53c8ef9.

@zhindes zhindes marked this pull request as ready for review February 5, 2024 22:34
.github/workflows/run_system_tests.yml Outdated Show resolved Hide resolved
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@zhindes zhindes enabled auto-merge (squash) February 5, 2024 22:42
@zhindes zhindes merged commit 1305bc1 into master Feb 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants