Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digital and Counter create channel tests #491

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Feb 7, 2024

What does this Pull Request accomplish?

This adds a test per DI, DO, CI, and CO create channel methods to validate that they can successfully be used. There is a small amount of functional validation that parameters are properly being passed through the layers of Python and underlying driver API.

Why should this Pull Request be merged?

This will give us confidence that we haven't broken anything as we refactor parts of the Python and driver stack.

What testing has been done?

$ poetry run ni-python-styleguide fix tests && poetry run ni-python-styleguide lint tests && poetry run pytest -rs
================================ test session starts ================================
platform win32 -- Python 3.10.10, pytest-7.4.2, pluggy-1.3.0
rootdir: C:\dev\nidaqmx-python
configfile: pyproject.toml
testpaths: tests
plugins: cov-4.1.0, mock-3.11.1
collected 1529 items
...
============= 1331 passed, 131 skipped, 67 xfailed in 116.93s (0:01:56) =============

@zhindes zhindes marked this pull request as ready for review February 7, 2024 22:31
Copy link

github-actions bot commented Feb 7, 2024

Test Results

    30 files  ±    0      30 suites  ±0   35m 2s ⏱️ +22s
 1 530 tests +   98   1 350 ✅ +   98    180 💤 ±0  0 ❌ ±0 
23 580 runs  +1 470  20 960 ✅ +1 470  2 620 💤 ±0  0 ❌ ±0 

Results for commit 547bf2e. ± Comparison against base commit 7119a3f.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

tests/conftest.py Outdated Show resolved Hide resolved
tests/component/_task_modules/channels/test_ci_channel.py Outdated Show resolved Hide resolved
@zhindes zhindes enabled auto-merge (squash) February 8, 2024 18:59
@zhindes zhindes merged commit 457077b into master Feb 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants