Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raw-read Function Names Spacing Issue #492

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Fix raw-read Function Names Spacing Issue #492

merged 7 commits into from
Feb 14, 2024

Conversation

charitylxy
Copy link
Collaborator

@charitylxy charitylxy commented Feb 8, 2024 •
edited
Loading

What does this Pull Request accomplish?

This PR aims to address the issue brought up in #38

  • readall modified to read_all
  • readinto modified to read_into

Why should this Pull Request be merged?

To standardize the raw-read function names spacing.

What testing has been done?

  • Ran nidaqmx-python code generator and validate the generated file
  • Added and modified regression tests for the related test cases and all tests passed in local machine
    Test cases for deprecated function:
    image
    Test cases for new function name:
    image

@charitylxy charitylxy linked an issue Feb 8, 2024 that may be closed by this pull request
No spacing in raw-read function names #38
Closed
@charitylxy charitylxy removed a link to an issue Feb 8, 2024
No spacing in raw-read function names #38
Closed
@charitylxy charitylxy linked an issue Feb 8, 2024 that may be closed by this pull request
No spacing in raw-read function names #38
Closed
@charitylxy charitylxy marked this pull request as ready for review February 8, 2024 07:16
@charitylxy charitylxy requested a review from bkeryan February 9, 2024 04:21
bkeryan
bkeryan approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

generated/nidaqmx/_task_modules/in_stream.py Outdated Show resolved Hide resolved
@charitylxy charitylxy merged commit 173f46b into ni:master Feb 14, 2024
16 checks passed
@DeborahOoi96 DeborahOoi96 mentioned this pull request Feb 16, 2024
Closed
@charitylxy charitylxy deleted the users/charitylxy/naming-read branch February 20, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeborahOoi96 DeborahOoi96 DeborahOoi96 left review comments

@zhindes zhindes zhindes approved these changes

@bkeryan bkeryan bkeryan approved these changes

@maxxboehme maxxboehme Awaiting requested review from maxxboehme maxxboehme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No spacing in raw-read function names
4 participants
@charitylxy @bkeryan @zhindes @DeborahOoi96