Add tests to verify closing task in event callback does not crash or error #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texasaggie97
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
zhindes
previously requested changes
Apr 3, 2024
zhindes
approved these changes
Apr 3, 2024
texasaggie97
deleted the
users/texasaggie97/test-clearing-task-in-callback
branch
bkeryan
reviewed
Apr 11, 2024
texasaggie97
added a commit
that referenced
this pull request
Apr 15, 2024
1 task
texasaggie97
added a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
DAQmx allows stopping and closing the task in an event callback. Test that is does not crash and behaves properly.
Why should this Pull Request be merged?
Improve test coverage
What testing has been done?