Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hightime library #560

Merged

Conversation

WayneDroid
Copy link
Collaborator

What does this Pull Request accomplish?

  • updated hightime version to 2.2
  • replaced total_seconds with precision_total_seconds for hightime datetime
  • updated test cases involved femtosecond and yoctosecond use case

Why should this Pull Request be merged?

Update hightime library to have better precision on total seconds.

What testing has been done?

poetry run pytest - pass

image

Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some comments is all! FYI brad is out, so feel free to complete when you add those

tests/unit/test_grpc_time.py Show resolved Hide resolved
@WayneDroid WayneDroid merged commit e609ae6 into ni:master Apr 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants