Merged
Conversation
WayneDroid
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
WayneDroid
commented
Apr 23, 2024
zhindes
requested changes
Apr 23, 2024
examples/analog_out/cont_gen_voltage_wfm_int_clk_every_n_samples_event.py
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Apr 23, 2024
examples/analog_out/cont_gen_voltage_wfm_int_clk_every_n_samples_event.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Apr 23, 2024
bkeryan
reviewed
Apr 23, 2024
bkeryan
reviewed
May 2, 2024
examples/analog_out/cont_gen_voltage_wfm_int_clk_every_n_samples_event.py
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
May 2, 2024
examples/analog_out/cont_gen_voltage_wfm_int_clk_every_n_samples_event.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
May 2, 2024
bkeryan
requested changes
May 6, 2024
examples/analog_out/cont_gen_voltage_wfm_int_clk_every_n_samples_event.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
May 15, 2024
bkeryan
approved these changes
May 28, 2024
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
examples/analog_out/cont_gen_voltage_wfm_int_clk_every_n_samples_event.py
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
May 29, 2024
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestion: delete types from the docstring
zhindes
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Add AO examples for release 1.0.
What testing has been done?
run
poetry run pytest tests/ -q- pass