tests: Improve _bool_array_to_int in DI reader test #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
reversed(...)
to reverse the bool array.int(bit)
to explicitly convert the NumPy array element to a Pythonint
, which prevents setting the sign bit with large ports and returning negative numbers.DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
Why should this Pull Request be merged?
Fix issues I discovered when writing another test.
What testing has been done?
poetry run pytest -v .\tests\component\test_stream_readers_di.py
passes with LibraryInterpreter. (I don't currently have NI gRPC Device Server installed.)