tox.ini: Enable Python 3.13 #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The py64 runner has been updated but the py32 runner has not. |
zhindes
reviewed
Oct 17, 2024
zhindes
approved these changes
Oct 17, 2024
|
I double-checked the output to make sure it's actually running 3.13. py32: https://github.com/ni/nidaqmx-python/actions/runs/11376831246/job/31650061261?pr=646 This is due to the fact that creating an updated py32 image failed. py64: https://github.com/ni/nidaqmx-python/actions/runs/11376831246/job/31650061486?pr=646 py64 works and py32 fails gracefully, so I guess this PR doesn't have to wait for the new py32 image. I will manually run the tests on 32-bit Python, though. |
|
bkeryan
added a commit
that referenced
this pull request
Oct 17, 2024
(cherry picked from commit dab722c)
1 task
bkeryan
added a commit
that referenced
this pull request
Oct 17, 2024
* nidaqmx: Fix installation with Python 3.13 (#645) * tests: Fix OverflowError: Python integer 36767 out of bounds for int16 * tests: Skip more examples * nidaqmx: Update dependency versions for Python 3.13 support * Update poetry.lock * GitHub: Enable unit tests on Python 3.13 * tests: Reformat with black * tests: Fix E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` * nidaqmx: Allow newer types-protobuf * nidaqmx: Update poetry.lock (cherry picked from commit ee791a3) * tox: Enable Python 3.13 (#646) (cherry picked from commit dab722c) * nidaqmx: Add Python 3.13 trove classifier and update changelog (#649) * nidaqmx: Add Python 3.13 trove classifier * nidaqmx: Update changelog (cherry picked from commit ba8a962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Enable running system tests with Python 3.13.
Why should this Pull Request be merged?
Finish fixing #644
What testing has been done?
None