Skip to content

Commit

Permalink
Exclude Apache Arrow and eslint from Renovate major updates (#2321)
Browse files Browse the repository at this point in the history
# Pull Request

## 🤨 Rationale

This Renovate PR #2318 is failing builds because it tries to update
eslint to 9.x but javascript-styleguide is only compatible with 8.x.

We also don't want Renovate to do major updates of apache arrow in
either npm or nuget because it's pinned and needs to stay in sync
between npm and nuget so should probably be manually handled.

## 👩‍💻 Implementation

Update Renovate config to exclude those dependencies. I got the names of
the dependencies from `packages.json` for npm and `packages.lock.json`
for nuget.

## 🧪 Testing

After this goes in we can retrigger the Renovate algorithm and see if
the major bump excludes these.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
jattasNI authored Aug 1, 2024
1 parent 5dfb654 commit 186667b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
"matchDepTypes": ["dependencies", "devDependencies", "peerDependencies"],
"excludePackagePatterns":[
"^@angular",
"apache-arrow",
"comlink",
"eslint",
"ng-packagr",
"playwright",
"remark-gfm",
Expand All @@ -41,6 +43,7 @@
"groupName": "nuget dependencies",
"matchManagers": ["nuget"],
"excludePackagePatterns":[
"Apache.Arrow",
"NI.CSharp.Analyzers",
"Microsoft.Playwright"
],
Expand Down

0 comments on commit 186667b

Please sign in to comment.