updates

ni · Mar 26, 2024 · 8da6dcc · 8da6dcc
1 parent 441c2e4
commit 8da6dcc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/nimble-components/package.json b/packages/nimble-components/package.json
@@ -46,7 +46,7 @@
     "test-webkit:verbose": "karma start karma.conf.verbose.js --browsers=WebkitHeadless --single-run --skip-tags SkipWebkit",
     "test-webkit:watch": "karma start karma.conf.js --browsers=WebkitHeadless --skip-tags SkipWebkit --watch-extensions js",
     "test-webkit": "karma start karma.conf.js --browsers=WebkitHeadless --single-run --skip-tags SkipWebkit",
-    "test": "npm run test-webkit"
+    "test": "npm run test-chrome && npm run test-firefox && npm run test-webkit"
   },
   "repository": {
     "type": "git",

diff --git a/packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts b/packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
@@ -20,8 +20,7 @@ class ElementReferences {
     public column1!: TableColumnDateText;
 }
 
-// eslint-disable-next-line no-restricted-globals
-fdescribe('TableColumnDateText', () => {
+describe('TableColumnDateText', () => {
     let table: Table<SimpleTableRecord>;
     let connect: () => Promise<void>;
     let disconnect: () => Promise<void>;

diff --git a/packages/nimble-components/src/table/testing/table.pageobject.ts b/packages/nimble-components/src/table/testing/table.pageobject.ts
@@ -357,7 +357,7 @@ export class TablePageObject<T extends TableRecord> {
 
     public async scrollToLastRowAsync(): Promise<void> {
         const scrollElement = this.tableElement.viewport;
-        scrollElement.scrollTop = scrollElement.scrollHeight;
+        scrollElement.scroll({ top: scrollElement.scrollHeight });
         await waitForUpdatesAsync();
     }
 

diff --git a/packages/nimble-components/src/table/tests/table.spec.ts b/packages/nimble-components/src/table/tests/table.spec.ts
@@ -79,7 +79,8 @@ async function setup(): Promise<Fixture<Table<SimpleTableRecord>>> {
     );
 }
 
-describe('Table', () => {
+// eslint-disable-next-line no-restricted-globals
+fdescribe('Table', () => {
     describe('with connection', () => {
         let element: Table<SimpleTableRecord>;
         let connect: () => Promise<void>;