Skip to content

Commit

Permalink
Merge branch 'main' into router-link-tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jattasNI committed Oct 9, 2024
2 parents ac3496e + f293446 commit b8adbaa
Show file tree
Hide file tree
Showing 26 changed files with 771 additions and 37 deletions.
22 changes: 11 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions packages/angular-workspace/nimble-angular/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@ni/nimble-angular",
"entries": [
{
"date": "Wed, 09 Oct 2024 19:24:18 GMT",
"version": "28.2.10",
"tag": "@ni/nimble-angular_v28.2.10",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@ni/nimble-angular",
"comment": "Bump @ni/nimble-components to v32.3.0",
"commit": "not available"
}
]
}
},
{
"date": "Thu, 26 Sep 2024 18:24:50 GMT",
"version": "28.2.9",
Expand Down
10 changes: 9 additions & 1 deletion packages/angular-workspace/nimble-angular/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# Change Log - @ni/nimble-angular

<!-- This log was last generated on Thu, 26 Sep 2024 18:24:50 GMT and should not be manually modified. -->
<!-- This log was last generated on Wed, 09 Oct 2024 19:24:18 GMT and should not be manually modified. -->

<!-- Start content -->

## 28.2.10

Wed, 09 Oct 2024 19:24:18 GMT

### Patches

- Bump @ni/nimble-components to v32.3.0

## 28.2.9

Thu, 26 Sep 2024 18:24:50 GMT
Expand Down
4 changes: 2 additions & 2 deletions packages/angular-workspace/nimble-angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ni/nimble-angular",
"version": "28.2.9",
"version": "28.2.10",
"description": "Angular components for the NI Nimble Design System",
"scripts": {
"invoke-publish": "npm run invoke-publish:setup && cd ../dist/nimble-angular && npm publish",
Expand Down Expand Up @@ -32,7 +32,7 @@
"@angular/forms": "^17.3.12",
"@angular/localize": "^17.3.12",
"@angular/router": "^17.3.12",
"@ni/nimble-components": "^32.2.10"
"@ni/nimble-components": "^32.3.0"
},
"dependencies": {
"tslib": "^2.2.0"
Expand Down
15 changes: 15 additions & 0 deletions packages/angular-workspace/spright-angular/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@ni/spright-angular",
"entries": [
{
"date": "Wed, 09 Oct 2024 19:24:18 GMT",
"version": "5.1.11",
"tag": "@ni/spright-angular_v5.1.11",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@ni/spright-angular",
"comment": "Bump @ni/spright-components to v4.1.11",
"commit": "not available"
}
]
}
},
{
"date": "Thu, 26 Sep 2024 18:24:50 GMT",
"version": "5.1.10",
Expand Down
10 changes: 9 additions & 1 deletion packages/angular-workspace/spright-angular/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# Change Log - @ni/spright-angular

<!-- This log was last generated on Thu, 26 Sep 2024 18:24:50 GMT and should not be manually modified. -->
<!-- This log was last generated on Wed, 09 Oct 2024 19:24:18 GMT and should not be manually modified. -->

<!-- Start content -->

## 5.1.11

Wed, 09 Oct 2024 19:24:18 GMT

### Patches

- Bump @ni/spright-components to v4.1.11

## 5.1.10

Thu, 26 Sep 2024 18:24:50 GMT
Expand Down
4 changes: 2 additions & 2 deletions packages/angular-workspace/spright-angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ni/spright-angular",
"version": "5.1.10",
"version": "5.1.11",
"description": "Angular components for NI Spright",
"scripts": {
"invoke-publish": "npm run invoke-publish:setup && cd ../dist/spright-angular && npm publish",
Expand All @@ -24,7 +24,7 @@
"peerDependencies": {
"@angular/common": "^17.3.12",
"@angular/core": "^17.3.12",
"@ni/spright-components": "^4.1.10"
"@ni/spright-components": "^4.1.11"
},
"dependencies": {
"tslib": "^2.2.0"
Expand Down
15 changes: 15 additions & 0 deletions packages/blazor-workspace/NimbleBlazor/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@ni/nimble-blazor",
"entries": [
{
"date": "Wed, 09 Oct 2024 19:24:18 GMT",
"version": "18.2.10",
"tag": "@ni/nimble-blazor_v18.2.10",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@ni/nimble-blazor",
"comment": "Bump @ni/nimble-components to v32.3.0",
"commit": "not available"
}
]
}
},
{
"date": "Thu, 26 Sep 2024 18:24:50 GMT",
"version": "18.2.9",
Expand Down
10 changes: 9 additions & 1 deletion packages/blazor-workspace/NimbleBlazor/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# Change Log - @ni/nimble-blazor

<!-- This log was last generated on Thu, 26 Sep 2024 18:24:50 GMT and should not be manually modified. -->
<!-- This log was last generated on Wed, 09 Oct 2024 19:24:18 GMT and should not be manually modified. -->

<!-- Start content -->

## 18.2.10

Wed, 09 Oct 2024 19:24:18 GMT

### Patches

- Bump @ni/nimble-components to v32.3.0

## 18.2.9

Thu, 26 Sep 2024 18:24:50 GMT
Expand Down
4 changes: 2 additions & 2 deletions packages/blazor-workspace/NimbleBlazor/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ni/nimble-blazor",
"version": "18.2.9",
"version": "18.2.10",
"description": "Blazor components for the NI Nimble Design System",
"scripts": {
"pack": "cross-env-shell dotnet pack -c Release -p:PackageVersion=$npm_package_version --output ../dist",
Expand All @@ -25,7 +25,7 @@
"!*"
],
"peerDependencies": {
"@ni/nimble-components": "^32.2.10",
"@ni/nimble-components": "^32.3.0",
"@ni/nimble-tokens": "^8.3.0",
"cross-env": "^7.0.3",
"rimraf": "^6.0.0"
Expand Down
15 changes: 15 additions & 0 deletions packages/blazor-workspace/SprightBlazor/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@ni/spright-blazor",
"entries": [
{
"date": "Wed, 09 Oct 2024 19:24:18 GMT",
"version": "2.1.11",
"tag": "@ni/spright-blazor_v2.1.11",
"comments": {
"patch": [
{
"author": "beachball",
"package": "@ni/spright-blazor",
"comment": "Bump @ni/spright-components to v4.1.11",
"commit": "not available"
}
]
}
},
{
"date": "Thu, 26 Sep 2024 18:24:50 GMT",
"version": "2.1.10",
Expand Down
10 changes: 9 additions & 1 deletion packages/blazor-workspace/SprightBlazor/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# Change Log - @ni/spright-blazor

<!-- This log was last generated on Thu, 26 Sep 2024 18:24:50 GMT and should not be manually modified. -->
<!-- This log was last generated on Wed, 09 Oct 2024 19:24:18 GMT and should not be manually modified. -->

<!-- Start content -->

## 2.1.11

Wed, 09 Oct 2024 19:24:18 GMT

### Patches

- Bump @ni/spright-components to v4.1.11

## 2.1.10

Thu, 26 Sep 2024 18:24:50 GMT
Expand Down
4 changes: 2 additions & 2 deletions packages/blazor-workspace/SprightBlazor/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ni/spright-blazor",
"version": "2.1.10",
"version": "2.1.11",
"description": "Blazor components for Spright",
"scripts": {
"pack": "cross-env-shell dotnet pack -c Release -p:PackageVersion=$npm_package_version --output ../dist",
Expand All @@ -25,7 +25,7 @@
"!*"
],
"peerDependencies": {
"@ni/spright-components": "^4.1.10",
"@ni/spright-components": "^4.1.11",
"cross-env": "^7.0.3",
"rimraf": "^6.0.0"
}
Expand Down
15 changes: 15 additions & 0 deletions packages/nimble-components/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@ni/nimble-components",
"entries": [
{
"date": "Wed, 09 Oct 2024 19:24:18 GMT",
"version": "32.3.0",
"tag": "@ni/nimble-components_v32.3.0",
"comments": {
"minor": [
{
"author": "20542556+mollykreis@users.noreply.github.com",
"package": "@ni/nimble-components",
"commit": "8aa7c1ee2a6fae665419b8a8d9c8f8e7e977c424",
"comment": "Implement error states on nimble-radio-group"
}
]
}
},
{
"date": "Tue, 08 Oct 2024 17:39:50 GMT",
"version": "32.2.10",
Expand Down
10 changes: 9 additions & 1 deletion packages/nimble-components/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# Change Log - @ni/nimble-components

<!-- This log was last generated on Thu, 26 Sep 2024 18:24:50 GMT and should not be manually modified. -->
<!-- This log was last generated on Wed, 09 Oct 2024 19:24:18 GMT and should not be manually modified. -->

<!-- Start content -->

## 32.3.0

Wed, 09 Oct 2024 19:24:18 GMT

### Minor changes

- Implement error states on nimble-radio-group ([ni/nimble@8aa7c1e](https://github.com/ni/nimble/commit/8aa7c1ee2a6fae665419b8a8d9c8f8e7e977c424))

## 32.2.10

Thu, 26 Sep 2024 18:24:50 GMT
Expand Down
2 changes: 1 addition & 1 deletion packages/nimble-components/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ni/nimble-components",
"version": "32.2.10",
"version": "32.3.0",
"description": "Styled web components for the NI Nimble Design System",
"scripts": {
"build": "npm run generate-icons && npm run generate-workers && npm run build-components && npm run bundle-components && npm run generate-scss",
Expand Down
12 changes: 10 additions & 2 deletions packages/nimble-components/src/radio-group/index.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import {
RadioGroup as FoundationRadioGroup,
radioGroupTemplate as template,
DesignSystem
} from '@microsoft/fast-foundation';
import { Orientation } from '@microsoft/fast-web-utilities';
import { attr } from '@microsoft/fast-element';
import { styles } from './styles';
import { template } from './template';
import type { ErrorPattern } from '../patterns/error/types';

declare global {
interface HTMLElementTagNameMap {
Expand All @@ -17,7 +19,13 @@ export { Orientation };
/**
* A nimble-styled grouping element for radio buttons
*/
export class RadioGroup extends FoundationRadioGroup {}
export class RadioGroup extends FoundationRadioGroup implements ErrorPattern {
@attr({ attribute: 'error-text' })
public errorText?: string;

@attr({ attribute: 'error-visible', mode: 'boolean' })
public errorVisible = false;
}

const nimbleRadioGroup = RadioGroup.compose({
baseName: 'radio-group',
Expand Down
Loading

0 comments on commit b8adbaa

Please sign in to comment.