Align nuget and npm package versions #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
requested review from
jattasNI,
fredvisser,
atmgrifter00 and
msmithNI
as code owners
rajsite
commented
May 22, 2023
|
fyi blazor owners since it's an old PR that was sitting around for a while @atmgrifter00 @msmithNI |
tested it out in spright and looks functional so gonna merge, if any owners have concerns can address in a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Realized that the nuget and npm package versions are out of sync. This happens because the nuget package that is published was currently built in the workflow pack phase. Which is immediately after build to save generated artifacts.
However those built nuget packages are using the wrong version number as they run before beachball bumps them. Following the nimble-angular example-ish we will regenerate the build output (in this case the built nupkg files) during publish.
👩💻 Implementation
Re-run npm pack during publish to pick-up beachball version changes.
🧪 Testing
Doing it live
✅ Checklist