Interactive column sizing #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmgrifter00
commented
Jun 23, 2023
atmgrifter00
commented
Jun 23, 2023
atmgrifter00
commented
Jun 23, 2023
mollykreis
reviewed
Jun 23, 2023
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
Jul 18, 2023
packages/nimble-components/src/table-column/base/tests/table-column.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/models/table-layout-manager.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/testing/table.pageobject.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/testing/table.pageobject.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/testing/table.pageobject.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/tests/table-column-sizing.spec.ts
Outdated
Show resolved
Hide resolved
….com/ni/nimble into table-column-sizing-cascade-and-grow
jattasNI
approved these changes
Jul 18, 2023
rajsite
reviewed
Jul 19, 2023
rajsite
reviewed
Jul 19, 2023
….com/ni/nimble into table-column-sizing-cascade-and-grow
rajsite
approved these changes
Jul 19, 2023
1 task
mollykreis
added a commit
that referenced
this pull request
Aug 2, 2023
…tent (#1408) # Pull Request ## 🤨 Rationale Fix a bug in the `nimble-table` where shift-selecting rows would incorrectly highlight all cell content within the selection range. ## 👩💻 Implementation Mark `documentShiftKeyDown` as `@observable` on the `Table`. This appears to have been accidentally removed in #1321. ## 🧪 Testing Manually tested that shift-selecting rows no longer selects the text in cells. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
👩💻 Implementation
Bulk of implementation is the creation of the new
TableLayoutManagerclass that is responsible for updating the various aspects of sizing state the table needs.Beyond that it was mainly just updating the
Tabletemplate to host the new interactive dividers, and a "glass pane"divto handle the disabling of hover states in template elements during a column resize operation.🧪 Testing
Added unit tests.
✅ Checklist