Add incubating nimble-card component
#1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohn1922
changed the title
nimble-card component
kjohn1922
commented
Oct 27, 2023
kjohn1922
commented
Oct 27, 2023
mollykreis
reviewed
Oct 27, 2023
packages/nimble-components/src/tests/component-status.stories.ts
Outdated
Show resolved
Hide resolved
mollykreis
approved these changes
Oct 30, 2023
jattasNI
approved these changes
Oct 30, 2023
jattasNI
reviewed
Oct 30, 2023
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
rajsite
reviewed
Nov 1, 2023
rajsite
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Initial component code for the
nimble-cardcomponent.See #296 and the
nimble-cardspec for more information.🤨 Rationale
This adds the initial
nimble-cardcomponent, storybook, and tests.I will add a "title" slot to the template in a future PR. Future PRs will also add Angular and Blazor support.
The styling in the component right now is intended as a placeholder. We will get styling from our designer and update the styles before releasing the Routines UI with the card component.
👩💻 Implementation
nimble-card🧪 Testing
✅ Checklist