-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a title slot to the Card component #1638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohn1922
commented
Nov 1, 2023
mollykreis
approved these changes
Nov 1, 2023
jattasNI
approved these changes
Nov 1, 2023
change/@ni-nimble-components-d70e99f7-8c44-4141-a566-77b59825e16e.json
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Nov 1, 2023
rajsite
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Add a title slot for the
nimble-card
component.See #296 and the
nimble-card
spec for more information.🤨 Rationale
The
title
slot in thenimble-card
component will make it easy for clients to add a title with the correct styling and to enforce consistency across usages.The style itself is still a placeholder. We'll apply styles from a visual design in a future PR, before releasing the Routines UI with the card component.
👩💻 Implementation
slot
withname="title"
to thenimble-card
templatesection
at the root of the component templatedisplay: contents
to allow thehost
display settings to apply directly to the slotted content.nimble-banner
with similar description text for the title.🧪 Testing
Updated storybook and matrix tests:
✅ Checklist