Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Angular support for the nimble-card #1646

Merged
merged 15 commits into from
Nov 8, 2023
Merged

Add Angular support for the nimble-card #1646

merged 15 commits into from
Nov 8, 2023

Conversation

kjohn1922
Copy link
Contributor

@kjohn1922 kjohn1922 commented Nov 2, 2023 •
edited
Loading

Pull Request

Add Angular support for the nimble-card component.

See #296 and the nimble-card spec for more information.

🤨 Rationale

We want to be able to use the nimble-card in Angular applications.

👩‍💻 Implementation

  • Add and export a new Angular directive and module for the nimble-card component
  • Update the component status table to "incubating" for Angular support

🧪 Testing

  • Added a basic unit test
  • Added an example to example-client-app:
    image

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@kjohn1922
Copy link
Contributor Author

"Performance Audit with Lighthouse" is failing the build. I don't see anything about Lighthouse in the README or CONTRIBUTING docs. Is there something I need to do that I'm missing?

@rajsite rajsite mentioned this pull request Nov 6, 2023
Closed
@kjohn1922 kjohn1922 marked this pull request as ready for review November 8, 2023 14:50
@rajsite rajsite enabled auto-merge (squash) November 8, 2023 15:27
@rajsite
Copy link
Member

rajsite commented Nov 8, 2023 •
edited
Loading

Don't need to wait on @jattasNI looks well covered 👍

@rajsite rajsite merged commit 57ee0e9 into main Nov 8, 2023
11 checks passed
@rajsite rajsite deleted the users/kelseyj/card-angular branch November 8, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

@mollykreis mollykreis mollykreis approved these changes

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjohn1922 @rajsite @mollykreis @atmgrifter00