-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Playwright version #1728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@msmithNI could you please buddy this change? |
msmithNI
reviewed
Jan 4, 2024
What's the behavior for devs locally once this goes in? Will the first |
msmithNI
approved these changes
Jan 4, 2024
m-akinc
commented
Jan 5, 2024
change/@ni-nimble-components-ee39f42f-cd28-42b3-837e-0df5b4842e70.json
Outdated
Show resolved
Hide resolved
m-akinc
requested review from
rajsite,
jattasNI and
atmgrifter00
as code owners
January 5, 2024 21:13
rajsite
reviewed
Jan 8, 2024
rajsite
reviewed
Jan 8, 2024
rajsite
reviewed
Jan 8, 2024
rajsite
requested changes
Jan 8, 2024
rajsite
reviewed
Jan 8, 2024
jattasNI
approved these changes
Jan 9, 2024
rajsite
reviewed
Jan 16, 2024
rajsite
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #1544
π©βπ» Implementation
postinstall
script to root package file that runsplaywright install --with-deps
to ensure browsers get installed.Expected 100.984375 to be 101.
andExpected 74.984375 to be 75.
I confirmed that this numerical imprecision is related to using fractional width units (e.g.1fr
).We still cannot have Renovate update the Playwright dependency because of the inconsistency of versions between the npm package and the nuget. E.g. currently the latest npm package is 1.40.1, but the latest nuget is only 1.40.0, so our build will fail as it tries to find a nuget with the same version as the npm package.
π§ͺ Testing
Pipeline build succeeds
β Checklist