Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Playwright version #1728

Merged
merged 12 commits into from
Jan 16, 2024
Merged

Update Playwright version #1728

merged 12 commits into from
Jan 16, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Jan 3, 2024

Pull Request

🀨 Rationale

Fixes #1544

πŸ‘©β€πŸ’» Implementation

  • Added postinstall script to root package file that runs playwright install --with-deps to ensure browsers get installed.
  • Bumped dependency versions of Playwright to 1.40.0 in nimble-components, nimble-blazor, and Angular workspace. They are now pinned to one version, because the root workspace package file now installs the browsers.
  • Fixed two table page object functions that were incorrect.
  • Added workaround (rounding cell width) for tests failing due to pulling in new version of Chrome browser (from 115.0.5790.75 to 120.0.6099.28). Six table interactive column resize tests began failing with errors like Expected 100.984375 to be 101. and Expected 74.984375 to be 75. I confirmed that this numerical imprecision is related to using fractional width units (e.g. 1fr).

We still cannot have Renovate update the Playwright dependency because of the inconsistency of versions between the npm package and the nuget. E.g. currently the latest npm package is 1.40.1, but the latest nuget is only 1.40.0, so our build will fail as it tries to find a nuget with the same version as the npm package.

πŸ§ͺ Testing

Pipeline build succeeds

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc
Copy link
Contributor Author

m-akinc commented Jan 4, 2024

@msmithNI could you please buddy this change?

@m-akinc m-akinc requested a review from msmithNI January 4, 2024 22:55
@msmithNI
Copy link
Contributor

msmithNI commented Jan 4, 2024

What's the behavior for devs locally once this goes in? Will the first npm run tdd command they run in nimble-components fail, until they do the npx playwright install? Assuming that message gets printed to the console that's probably fine, otherwise we may need to update the Contributing doc(s) to document that step.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@m-akinc m-akinc marked this pull request as ready for review January 5, 2024 21:13
package.json Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@m-akinc m-akinc requested a review from rajsite January 8, 2024 19:18
angular-workspace/package.json Outdated Show resolved Hide resolved
@m-akinc m-akinc requested a review from rajsite January 8, 2024 20:48
package.json Show resolved Hide resolved
@rajsite rajsite enabled auto-merge (squash) January 16, 2024 23:12
@rajsite rajsite merged commit 762a3cb into main Jan 16, 2024
10 checks passed
@rajsite rajsite deleted the users/makinc/update-playwright branch January 16, 2024 23:27
@rajsite
Copy link
Member

rajsite commented Jan 16, 2024

Ah dang, we all missed it but testing/ is public apis so this should have been a patch change, not a none change. @jattasNI @msmithNI @m-akinc Hopefully the change in behavior doesn't impact someone else' next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uptake newer Playwright version and fix breaking change
4 participants