Update spec with wafer map API decision #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Feb 19, 2024
munteannatan
requested review from
rajsite,
jattasNI and
mollykreis
as code owners
jattasNI
reviewed
Feb 19, 2024
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
1 task
jattasNI
reviewed
Feb 20, 2024
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Feb 21, 2024
jattasNI
reviewed
Feb 26, 2024
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Feb 28, 2024
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Feb 28, 2024
|
Don't need to wait for @mollykreis, but FYI @jattasNI this is ready for a final review |
jattasNI
approved these changes
Feb 28, 2024
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/specs/features/rendering.md
Outdated
Show resolved
Hide resolved
rajsite
added a commit
that referenced
this pull request
Mar 7, 2024
# Pull Request ## 🤨 Rationale Details about the API, implementation and other changes can be found in the spec file https://github.com/ni/nimble/blob/main/packages/nimble-components/src/wafer-map/specs/features/rendering.md. Other requirements are under review #1834. ## 👩💻 Implementation Created the new API `diesTable` property and changed the update cycle to use two rendering strategies. Created a new `WorkerRenderer` skeleton. Created storybook controls and data for the new api. ## 🧪 Testing unit testing created for the API access and update. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: rajsite <rajsite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Prototyped Apache Arrow API and recorded performance.
👩💻 Implementation
Updated the spec file.
Prototype can be found here #1788
🧪 Testing
N/A
✅ Checklist