-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Tip IxD Spec #1889
Merged
Merged
Toggle Tip IxD Spec #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredvisser
requested review from
rajsite,
jattasNI,
atmgrifter00 and
mollykreis
as code owners
March 6, 2024 22:41
mollykreis
reviewed
Mar 7, 2024
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Mar 12, 2024
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/toggle-tip/specs/toggle-tip-ixd.md
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Mar 13, 2024
mollykreis
approved these changes
Mar 13, 2024
rajsite
reviewed
Mar 18, 2024
rajsite
reviewed
Apr 15, 2024
rajsite
approved these changes
Apr 15, 2024
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Define the interaction design patterns needed to implement the nimble-toggle-tip Component
π©βπ» Implementation
Leveraged much of the pattern established by the Accordion IxD spec.
π§ͺ Testing
None
β Checklist