-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow icon column to be configured as fixed width #1907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@atmgrifter00, will you buddy this PR for me? |
atmgrifter00
reviewed
Mar 7, 2024
packages/nimble-components/src/table-column/icon/tests/table-column-icon.stories.ts
Outdated
Show resolved
Hide resolved
mollykreis
commented
Mar 7, 2024
packages/nimble-components/src/table-column/icon/tests/table-column-icon.spec.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
reviewed
Mar 7, 2024
atmgrifter00
reviewed
Mar 7, 2024
atmgrifter00
reviewed
Mar 7, 2024
packages/nimble-components/src/table/tests/table-column-sizing.spec.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
reviewed
Mar 7, 2024
This reverts commit fd64c39.
@atmgrifter00, can you re-buddy this PR for me now that there has been a significant change in the direction of the feature? |
mollykreis
changed the title
Fixed icon column width
Allow icon column to be configured as fixed width
Apr 25, 2024
atmgrifter00
approved these changes
Apr 29, 2024
rajsite
reviewed
Apr 29, 2024
packages/nimble-components/src/table-column/icon/tests/table-column-icon-matrix.stories.ts
Outdated
Show resolved
Hide resolved
…olumn-icon-matrix.stories.ts Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
…into fixed-icon-column-width
msmithNI
approved these changes
Apr 29, 2024
rajsite
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This change is part of #1873 and follows the decisions made in #1992
This change adds the ability to configure the
width-mode
of the icon column. When set toiconSize
, the column is a fixed width of 32px, cannot be resized, and hides its sorting & grouping indicators in the header.👩💻 Implementation
There were a number of changes that needed to be made within nimble to facilitate this change.
resizingDisabled
andhideHeaderIndicators
columnWidths
as being changed whenresizingDisabled
changes incolumnInternals
resizingDisabled === true
draggable
class to the dividers that can be dragged and making the presence of that class a condition in the CSS for showing the divider.indicators-hidden
on table columns wherehideHeaderIndicators === true
indicators-hidden
that, whentrue
, hides the sorting & grouping indicators in the column header.width-mode
attribute. When the attribute is changed,columnInternals
is updated with appropriate values forresizingDisabled
,hideHeaderIndicators
,minPixelWidth
, andpixelWidth
.🧪 Testing
Manually tested in storybook
Updated & added unit tests
✅ Checklist