Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable and tag tests failing in specific browsers #1941

Merged
merged 13 commits into from
Mar 18, 2024

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Mar 15, 2024

Pull Request

🤨 Rationale

One of the tasks in #1747 is to run nimble-components tests in WebKit and see if there are any new failures. There are several.

We also wanted to start tracking specific issues for each root cause rather than catch all issues like #1074 and #1075.

👩‍💻 Implementation

Marked each failing test with one of these specific issues:

Also re-enabled a couple of table header tests in Firefox which are now passing.

🧪 Testing

Ran tests in Playwright webkit browser, Firefox, and Safari and and all the enabled tests now pass.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI changed the title Cross browser test failures Disable and tag tests failing in specific browsers Mar 15, 2024
@jattasNI jattasNI marked this pull request as ready for review March 18, 2024 14:23
@jattasNI jattasNI requested a review from rajsite as a code owner March 18, 2024 14:23
@rajsite rajsite enabled auto-merge (squash) March 18, 2024 15:40
@rajsite rajsite merged commit a112528 into main Mar 18, 2024
10 checks passed
@rajsite rajsite deleted the cross-browser-test-failures branch March 18, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants