Disable and tag tests failing in specific browsers #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
One of the tasks in #1747 is to run nimble-components tests in WebKit and see if there are any new failures. There are several.
We also wanted to start tracking specific issues for each root cause rather than catch all issues like #1074 and #1075.
👩💻 Implementation
Marked each failing test with one of these specific issues:
Also re-enabled a couple of table header tests in Firefox which are now passing.
🧪 Testing
Ran tests in Playwright webkit browser, Firefox, and Safari and and all the enabled tests now pass.
✅ Checklist