Created Computations and Data Manager Experimental #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eannatan/experimental-computations
1 task
…eannatan/experimental-computations
…eannatan/experimental-computations
…eannatan/experimental-computations
…eannatan/experimental-computations
…eannatan/experimental-computations
rajsite
reviewed
Mar 26, 2024
rajsite
approved these changes
Mar 26, 2024
packages/nimble-components/src/wafer-map/modules/hover-handler.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/modules/experimental/hover-handler.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 26, 2024
packages/nimble-components/src/wafer-map/modules/prerendering.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 26, 2024
packages/nimble-components/src/wafer-map/tests/experimental-computations.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 26, 2024
packages/nimble-components/src/wafer-map/tests/experimental-computations.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 26, 2024
packages/nimble-components/src/wafer-map/tests/experimental-computations.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 26, 2024
packages/nimble-components/src/wafer-map/tests/experimental-data-manager.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 26, 2024
packages/nimble-components/src/wafer-map/tests/experimental-data-manager.spec.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Mar 26, 2024
packages/nimble-components/src/wafer-map/tests/wafer-map.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Created new computations experimental component with changed scales and diesTable iteration for finding the bounding box until arquero fixes.
The new scales will be able to be inverted without the need to create separate scales for the hover handler.
👩💻 Implementation
changed the scales and iteration over the diesTable
integrated the changes and the strategy swap with the wafermap and the experimental hover
🧪 Testing
copied spec classes for the new experimental modules.
updated hover handler spec.
adapted the data manager to the previous renderer for visual tests in storybook.
✅ Checklist