Update date-text column tests to pass on all browsers #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-akinc, will you buddy this PR for me? |
m-akinc
approved these changes
Mar 25, 2024
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
Outdated
Show resolved
Hide resolved
change/@ni-nimble-components-26aadfad-c24c-4ad0-ae8e-e75769665e95.json
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Mar 28, 2024
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
Show resolved
Hide resolved
rajsite
approved these changes
Mar 28, 2024
packages/nimble-components/src/table-column/date-text/tests/table-column-date-text.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Resolves #1940
👩💻 Implementation
Added a page object function to get the expected cell text for a given value/locale combination. The function internally uses
Intl.DateTimeFormatto determine the expected text, so that it will always return the correct value for a given browser. With this change, the tests still test all the column, cell, and group row formatting code without actually testing the nuances of the string returned fromIntl.DateTimeFormat.🧪 Testing
Ran the tests for the date-text column in WebKit on my machine (Windows 10) and on the pipeline to verify they pass on both.
✅ Checklist