Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor column placeholder #1967

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Blazor column placeholder #1967

merged 5 commits into from
Mar 28, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🀨 Rationale

Adds Blazor support for column placeholders, which is part of #1538.

πŸ‘©β€πŸ’» Implementation

Add Placeholder to the 5 columns that support that property.

πŸ§ͺ Testing

Added unit tests

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, will you buddy this PR for me?

Copy link
Contributor

@atmgrifter00 atmgrifter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a usage of this in the example project?

@mollykreis
Copy link
Contributor Author

Should we add a usage of this in the example project?

We decided in the corresponding Angular PR not to do this. (See #1966)

@mollykreis mollykreis marked this pull request as ready for review March 28, 2024 14:07
@mollykreis mollykreis enabled auto-merge (squash) March 28, 2024 20:24
@mollykreis mollykreis merged commit 446055c into main Mar 28, 2024
11 checks passed
@mollykreis mollykreis deleted the blazor-column-placeholder branch March 28, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants