Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent storybook matrix states refactoring #1970

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Consistent storybook matrix states refactoring #1970

merged 11 commits into from
Mar 28, 2024

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Mar 27, 2024

Pull Request

🤨 Rationale

Makes the following bits more consistent in the storybook matrix tests:

  • All the states enums use the normal enum pattern (instead of programmatic enum definition which looses some typing)
  • All the states are defined first before the storybook metadata definition
  • All the states use the naming convention of blahStates for the state dimension and BlahState for the individual state type
  • File specific states were put in alphabetical order

👩‍💻 Implementation

See above.

🧪 Testing

Should not result in any changes in stories except for one change in dialogs where I have the state name render on the page instead of the state value which is a long CSS string.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed. Hoping folks just copy and paste the patterns, didn't seem worth a doc update.

@rajsite rajsite changed the title Strict sb enums Consistent storybook matrix states Mar 27, 2024
@rajsite rajsite changed the title Consistent storybook matrix states Consistent storybook matrix states refactoring Mar 27, 2024
@rajsite rajsite marked this pull request as ready for review March 27, 2024 23:07
@rajsite rajsite enabled auto-merge (squash) March 27, 2024 23:30
@rajsite rajsite disabled auto-merge March 28, 2024 04:04
@rajsite
Copy link
Member Author

rajsite commented Mar 28, 2024

@jattasNI think the change is pretty non-controversial and minor. Bypassing owners but can address concerns in a follow-up.

@rajsite rajsite merged commit 0973d48 into main Mar 28, 2024
11 checks passed
@rajsite rajsite deleted the strict-sb-enums branch March 28, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant