-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a couple issues with anchor styling #1972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mollykreis mind buddying this for me? |
mollykreis
reviewed
Mar 28, 2024
mollykreis
approved these changes
Apr 1, 2024
jattasNI
approved these changes
Apr 1, 2024
rajsite
reviewed
Apr 1, 2024
rajsite
approved these changes
Apr 10, 2024
rajsite
reviewed
Apr 10, 2024
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
I noticed a few differences between our anchor styling and the Figma design:
underline-hidden
is setunderline-hidden
should not have underlines when clicked/active (despite mouse hover)prominent
appearance. (Figma does not actually provide a design for theprominent
appearance under the color theme, but we can extrapolate from the other themes.)👩💻 Implementation
I am addressing issues 3-5. Tech debt issue #2011 tracks items 1 and 2.
To simplify things, I rewrote the anchor styles using CSS cascade layers.
🧪 Testing
Storybook snapshots
✅ Checklist