-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork FAST Combobox. #1973
Merged
Merged
Fork FAST Combobox. #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fork-fast-combobox
…o fork-fast-combobox
…o fork-fast-combobox
atmgrifter00
commented
Mar 29, 2024
jattasNI
approved these changes
Mar 29, 2024
jattasNI
reviewed
Mar 29, 2024
rajsite
approved these changes
Apr 2, 2024
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As part of the effort to bring the
Combobox
implementation in alignment with theSelect
, namely with how we handle controlling the visibility of the options in the dropdown, as well as the need to register options as part of theconnectedCallback
hook, it makes sense to fork the FASTCombobox
implementation into our own, as we did with theSelect
, to make it more clear what is happening within our own implementation for the various new behaviors we require.👩💻 Implementation
Essentially bringing over the current
Combobox
implementation from the FASTarchives/fast-element1
branch into our own. Copied the FASTFormAssociatedCombobox
that ourCombobox
now extends.🧪 Testing
Ran existing unit tests. Manual testing. Verified that our existing tests still replicate all of the tests currently in the FAST
archives/fast-element1
repo.✅ Checklist