Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork FAST Combobox. #1973

Merged
merged 16 commits into from
Apr 4, 2024
Merged

Fork FAST Combobox. #1973

merged 16 commits into from
Apr 4, 2024

Conversation

atmgrifter00
Copy link
Contributor

@atmgrifter00 atmgrifter00 commented Mar 28, 2024

Pull Request

🤨 Rationale

As part of the effort to bring the Combobox implementation in alignment with the Select, namely with how we handle controlling the visibility of the options in the dropdown, as well as the need to register options as part of the connectedCallback hook, it makes sense to fork the FAST Combobox implementation into our own, as we did with the Select, to make it more clear what is happening within our own implementation for the various new behaviors we require.

👩‍💻 Implementation

Essentially bringing over the current Combobox implementation from the FAST archives/fast-element1 branch into our own. Copied the FAST FormAssociatedCombobox that our Combobox now extends.

🧪 Testing

Ran existing unit tests. Manual testing. Verified that our existing tests still replicate all of the tests currently in the FAST archives/fast-element1 repo.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00 atmgrifter00 marked this pull request as ready for review March 28, 2024 16:24
@atmgrifter00 atmgrifter00 marked this pull request as draft March 28, 2024 16:24
@atmgrifter00 atmgrifter00 marked this pull request as ready for review March 29, 2024 14:44
packages/nimble-components/src/combobox/index.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/combobox/index.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/combobox/index.ts Outdated Show resolved Hide resolved
@rajsite rajsite enabled auto-merge (squash) April 4, 2024 17:37
@rajsite rajsite merged commit 53b2c45 into main Apr 4, 2024
11 checks passed
@rajsite rajsite deleted the fork-fast-combobox branch April 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants