-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spright-components
package
#1986
Conversation
@jattasNI Not sure it makes sense for someone other than you or Milan to buddy this, so I thought you could take an initial look before having other people review. |
cfacfe9
to
dbb6edf
Compare
change/@ni-spright-components-08e968ac-291f-4c66-949e-115ca77deef2.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for comments to be addressed
"@microsoft/fast-element": "^1.12.0", | ||
"@microsoft/fast-foundation": "^2.49.6", | ||
"@microsoft/fast-web-utilities": "^6.0.0", | ||
"@ni/nimble-components": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a minor change... in a published package that would mean any version of nimble-components is valid which is not accurate. You just need to get it aligned with what is the latest in main and synced to your branch. Beachball handles revving it and keeping it aligned after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I had been thinking of "*"
as "latest", since it allows the newest version, but of course that's not what it means. Switched it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"latest" does exist but we should use semantic version ranges to specify the version we actually test against. i.e. latest changes day-to-day and doesn't care about major versions, etc. If you want to make sure the mental model for how semver works is aligned we should discuss offline as you're setting up more packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came up in the wild for a third party package using wildcard specifiers for dependencies as an example: DefinitelyTyped/DefinitelyTyped#69355 (comment)
Even though the linkify-it package did a major version release to specify a breaking change users of markdown-it (directly or indirectly) were broken by the major change because markdown-it used a wildcard specifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs correct package version management
Pull Request
π€¨ Rationale
Resolves #1974
π©βπ» Implementation
packages/spright-components
spright-accordion
component with unit testsREADME
andCONTRIBUTING
Configuration includes some Storybook-related content (just to avoid having to remove and re-add later), but the actual Storybook support for
spright-components
will be a separate submission.π§ͺ Testing
Builds and tests pass
β Checklist