Improve TColumnConfig typing on columns that extend TableColumnTextBase #1997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Resolves #1964
π©βπ» Implementation
TableColumnTextBase
cannot simply be made generic because TypeScript doesn't support generics and mixins together: microsoft/TypeScript#26154.Therefore, each concrete instance of
TableColumnTextBase
should add its own mixins in a way that they get mixed intoTableColumnTextBase<TColumnConfig>
rather thanTableColumn
. To avoid code duplicate, I created a function,mixinTextBase
, that mixes in the appropriate mixins forTableColumnTextBase
.π§ͺ Testing
this.columnInternals.columnConfig
is correct for a column usingmixinTextBase
β Checklist