-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for icon mappings and spinner mappings to show/hide their text within a table's cells #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@atmgrifter00, will you buddy this PR for me? |
atmgrifter00
approved these changes
Apr 12, 2024
msmithNI
approved these changes
Apr 15, 2024
msmithNI
reviewed
Apr 15, 2024
packages/nimble-blazor/NimbleBlazor/Components/NimbleMappingIcon.razor.cs
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Apr 16, 2024
packages/nimble-components/src/table-column/enum-base/models/mapping-spinner-config.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Apr 16, 2024
rajsite
reviewed
Apr 16, 2024
packages/nimble-components/src/table-column/enum-base/models/mapping-spinner-config.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Apr 16, 2024
packages/nimble-components/src/table-column/enum-base/models/mapping-icon-config.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Apr 16, 2024
packages/nimble-components/src/table-column/enum-base/models/mapping-spinner-config.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Apr 16, 2024
packages/nimble-components/src/table-column/icon/cell-view/index.ts
Outdated
Show resolved
Hide resolved
mollykreis
commented
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
This updates the
nimble-mapping-icon
andnimble-mapping-spinner
elements to be aligned with the changes described in #1992.π©βπ» Implementation
text-hidden
tonimble-mapping-icon
andnimble-mapping-spinner
text-hidden
to mappings in order to keep their existing behaviorMappingIconConfig
andMappingSpinnerConfig
to be more alignedViewTemplate
to render a spinner, icon, or blanktitle
andaria-*
attributes based on the configurationMappingIconConfig
andMappingSpinnerConfig
) and to render the text based on thetext-hidden
attributeπ§ͺ Testing
β Checklist