Don't allow use of the nullish coalescing operator in templates #2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Resolves #1843
I did an evaluation of how observables work within FAST templates. A longer explanation of what is and is not allowed can be found in the discussion within the linked issue. The only issue I found within nimble code was the usage of
??
in templates, which may not correctly be identified as a volatile binding. Therefore, I've rewritten the bindings that previously used??
and added a lint rule fortemplate.ts
files that disallows usage of??
.👩💻 Implementation
See Rationale
🧪 Testing
All existing tests still pass
Verified that the new lint rule catches instances of
??
intemplate.ts
files✅ Checklist