Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select - no longer update value while navigating dropdown #2029

Merged
merged 47 commits into from
May 7, 2024
Merged

Select - no longer update value while navigating dropdown #2029

merged 47 commits into from
May 7, 2024

Commits on Apr 22, 2024

  1. Change Select to not update value as you navigate options in dropdown.

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    29ec3cd View commit details
    Browse the repository at this point in the history

  2. Change files

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cd06c39 View commit details
    Browse the repository at this point in the history

  3. Slight renaming.

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    26700f0 View commit details
    Browse the repository at this point in the history

  4. Minor change with test.

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2984113 View commit details
    Browse the repository at this point in the history

  5. Remove fit.

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6b089fa View commit details
    Browse the repository at this point in the history

  6. Linting

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2a65f92 View commit details
    Browse the repository at this point in the history

  7. prettier

    @atmgrifter00
    atmgrifter00 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    652642f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Fix issue with Listbox typeahead changing selectedIndex.

    @atmgrifter00
    atmgrifter00 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a4709e3 View commit details
    Browse the repository at this point in the history

  2. Linting.

    @atmgrifter00
    atmgrifter00 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    11c2611 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Revert previous solution for dealing with typeahead, and instead prov… 

    …ide override for typeaheadBufferChanged.
    @atmgrifter00
    atmgrifter00 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    25b9213 View commit details
    Browse the repository at this point in the history

  2. Test doc update.

    @atmgrifter00
    atmgrifter00 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2a1fd87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    23b201e View commit details
    Browse the repository at this point in the history

  4. Code clean up.

    @atmgrifter00
    atmgrifter00 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8f69548 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'select-no-value-update-refactor' of https://github.com/… 

    …ni/nimble into select-no-value-update-refactor
    @atmgrifter00
    atmgrifter00 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    62a714e View commit details
    Browse the repository at this point in the history

  6. Linting.

    @atmgrifter00
    atmgrifter00 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    08e2f7c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d769813 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    429665b View commit details
    Browse the repository at this point in the history

  9. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2cde4ea View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Code clean up.

    @atmgrifter00
    atmgrifter00 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b162f8b View commit details
    Browse the repository at this point in the history

  2. Reverting a change.

    @atmgrifter00
    atmgrifter00 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d74b6ee View commit details
    Browse the repository at this point in the history

  3. Fixes and tests.

    @atmgrifter00
    atmgrifter00 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9f6c6d6 View commit details
    Browse the repository at this point in the history

  4. Fix tests.

    @atmgrifter00
    atmgrifter00 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d9626e4 View commit details
    Browse the repository at this point in the history

  5. Fix matrix tests.

    @atmgrifter00
    atmgrifter00 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f096b79 View commit details
    Browse the repository at this point in the history

  6. Fix styling for other dropdown controls.

    @atmgrifter00
    atmgrifter00 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    016026f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Update packages/nimble-components/src/select/testing/select.pageobjec… 

    …t.ts

Co-authored-by: mollykreis <20542556+mollykreis@users.noreply.github.com>
    @atmgrifter00 @mollykreis
    atmgrifter00 and mollykreis authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3edd7f5 View commit details
    Browse the repository at this point in the history

  2. Handle PR feedback. Fixes/tests.

    @atmgrifter00
    atmgrifter00 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3a71144 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'select-no-value-update-refactor' of https://github.com/… 

    …ni/nimble into select-no-value-update-refactor
    @atmgrifter00
    atmgrifter00 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    270f313 View commit details
    Browse the repository at this point in the history

  4. Slight change with test.

    @atmgrifter00
    atmgrifter00 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    dc3329f View commit details
    Browse the repository at this point in the history

  5. Revert change

    @atmgrifter00
    atmgrifter00 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    98160ff View commit details
    Browse the repository at this point in the history

  6. Style fix.

    @atmgrifter00
    atmgrifter00 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    04f0916 View commit details
    Browse the repository at this point in the history

  7. Simplify CSS.

    @atmgrifter00
    atmgrifter00 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a9dc531 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    03cdc29 View commit details
    Browse the repository at this point in the history

  2. Fix build.

    @atmgrifter00
    atmgrifter00 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    042d2b0 View commit details
    Browse the repository at this point in the history

  3. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7d4ba9a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Handle PR feedback.

    @atmgrifter00
    atmgrifter00 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6f22ec7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    68f22d1 View commit details
    Browse the repository at this point in the history

  3. Fix test failure.

    @atmgrifter00
    atmgrifter00 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    866c6de View commit details
    Browse the repository at this point in the history

  4. Merge branch 'select-no-value-update-refactor' of https://github.com/… 

    …ni/nimble into select-no-value-update-refactor
    @atmgrifter00
    atmgrifter00 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0ccd719 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5f96ab1 View commit details
    Browse the repository at this point in the history

  2. Update packages/nimble-components/src/select/styles.ts 

    Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
    @atmgrifter00 @rajsite
    atmgrifter00 and rajsite authored May 6, 2024
    Configuration menu
    Copy the full SHA
    7b4c601 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'select-no-value-update-refactor' of https://github.com/… 

    …ni/nimble into select-no-value-update-refactor
    @atmgrifter00
    atmgrifter00 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5c79b29 View commit details
    Browse the repository at this point in the history

  4. Handle PR feedback

    @atmgrifter00
    atmgrifter00 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7087522 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored May 6, 2024
    Configuration menu
    Copy the full SHA
    061d9cc View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Rename page object method.

    @atmgrifter00
    atmgrifter00 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0d0bb13 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'select-no-value-update-refactor' of https://github.com/… 

    …ni/nimble into select-no-value-update-refactor
    @atmgrifter00
    atmgrifter00 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9b69c68 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into select-no-value-update-refactor

    @atmgrifter00
    atmgrifter00 authored May 7, 2024
    Configuration menu
    Copy the full SHA
    571973f View commit details
    Browse the repository at this point in the history

  4. Update packages/storybook/src/nimble/select/select-matrix.stories.ts

    @rajsite
    rajsite authored May 7, 2024
    Configuration menu
    Copy the full SHA
    dd79cd5 View commit details
    Browse the repository at this point in the history