Top-level script command tweaks and README updates #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
commented
May 5, 2024
rajsite
commented
May 5, 2024
rajsite
changed the title
rajsite
commented
May 5, 2024
rajsite
commented
May 5, 2024
rajsite
commented
May 5, 2024
mollykreis
approved these changes
May 6, 2024
fredvisser
reviewed
May 6, 2024
fredvisser
reviewed
May 6, 2024
fredvisser
reviewed
May 6, 2024
fredvisser
approved these changes
May 6, 2024
jattasNI
approved these changes
May 6, 2024
fredvisser
approved these changes
May 6, 2024
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Updates the top-level commands to commandeer
npm run validateto run lint and test concurrently (the formernpm run concurrently-lint-test), adds a top-levelnpm run storybookcommand, and updates the top-level README and CONTRIBUTING for the new packages and commands.👩💻 Implementation
See above.
🧪 Testing
Ran the
npm run storybookcommand locally and verified tweaking nimble-components or spright-components is detected and can recompile.✅ Checklist