Create nimble-mapping-empty component #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-akinc, will you buddy this PR for me? |
m-akinc
approved these changes
May 7, 2024
packages/storybook/src/nimble/mapping/empty/mapping-empty.stories.ts
Outdated
Show resolved
Hide resolved
packages/storybook/src/nimble/mapping/empty/mapping-empty.stories.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
May 7, 2024
rajsite
reviewed
May 7, 2024
packages/nimble-components/src/table-column/mapping/tests/table-column-mapping.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
May 9, 2024
packages/storybook/src/nimble/table-column/mapping/table-column-mapping.mdx
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
May 9, 2024
jattasNI
approved these changes
May 9, 2024
packages/storybook/src/nimble/table-column/mapping/table-column-mapping.mdx
Show resolved
Hide resolved
…nto nimble-mapping-empty
1 task
mollykreis
added a commit
that referenced
this pull request
May 10, 2024
# Pull Request ## 🤨 Rationale #2077 added the `MappingEmpty` component to `nimble-components`. This PR now adds that component to `nimble-blazor` and `nimble-angular`. ## 👩💻 Implementation - Added support to Angular and Blazor for `nimble-mapping-empty` - Updated both example apps to use the empty mapping element in the table ## 🧪 Testing - Created new auto tests following existing patterns - Verified the new mapping works correctly in the Angular & Blazor example apps ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As part of #1992, we decided to create a
nimble-mapping-emptycomponent that would allow a cell to render as blank for a given mapping while still having text provided for use in group rows.This PR creates that component within
nimble-components. Support for Blazor and Angular will be added in a subsequent PR.👩💻 Implementation
nimble-mapping-emptycomponent🧪 Testing
✅ Checklist