Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select option hover #2078

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix select option hover #2078

merged 2 commits into from
May 7, 2024

Conversation

atmgrifter00
Copy link
Contributor

@atmgrifter00 atmgrifter00 commented May 7, 2024 •
edited by jattasNI
Loading

Pull Request

🤨 Rationale

In #2029 I broke the hover styling for non-selected options. This fixes it.

👩‍💻 Implementation

Tiny CSS change.

🧪 Testing

Manual. As this is hover-based, a matrix test didn't seem possible.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

jattasNI
jattasNI approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I edited your PR description to link to the PR in question just to tie everything together.

change/@ni-nimble-components-67287dba-5fb3-4314-ab2a-5c68051c6ca7.json Show resolved Hide resolved
@rajsite rajsite merged commit 7feb69d into main May 7, 2024
13 checks passed
@rajsite rajsite deleted the fix-select-option-hover branch May 7, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jattasNI jattasNI jattasNI approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atmgrifter00 @rajsite @jattasNI