-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Blazor docs for Spright and workspace change #2083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure the whole team really needs to review, so I'm going to add @msmithNI to do an initial/buddy review, then add Meyer and Jesse afterwards. I'll probably FYI-tag Milan, too. |
msmithNI
approved these changes
May 8, 2024
@mollykreis @fredvisser I don't think there's really anything here for you to review. @rajsite It's up to your discretion to review if you like. |
rajsite
reviewed
May 8, 2024
rajsite
reviewed
May 8, 2024
jattasNI
approved these changes
May 8, 2024
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com> Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
msmithNI
approved these changes
May 8, 2024
atmgrifter00
approved these changes
May 9, 2024
fredvisser
approved these changes
May 9, 2024
rajsite
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Closes #1976
π©βπ» Implementation
README.md
into newNimbleBlazor/README.md
file. Some content remains in the workspaceREADME.md
.CONTRIBUTING.md
intoNimbleBlazor/
README.md
andCONTRIBUTING.md
inSprightBlazor/
π§ͺ Testing
N/A
β Checklist