Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Blazor docs for Spright and workspace change #2083

Merged
merged 10 commits into from
May 9, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 8, 2024

Pull Request

🀨 Rationale

Closes #1976

πŸ‘©β€πŸ’» Implementation

  • Moved most of previous, workspace README.md into new NimbleBlazor/README.md file. Some content remains in the workspace README.md.
  • Moved workspace CONTRIBUTING.md into NimbleBlazor/
  • Created new README.md and CONTRIBUTING.md in SprightBlazor/
  • Fixed link paths to Blazor documentation from other documentation

πŸ§ͺ Testing

N/A

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc
Copy link
Contributor Author

m-akinc commented May 8, 2024

I'm not sure the whole team really needs to review, so I'm going to add @msmithNI to do an initial/buddy review, then add Meyer and Jesse afterwards. I'll probably FYI-tag Milan, too.

@m-akinc m-akinc requested a review from msmithNI May 8, 2024 17:28
@m-akinc
Copy link
Contributor Author

m-akinc commented May 8, 2024

@mollykreis @fredvisser I don't think there's really anything here for you to review. @rajsite It's up to your discretion to review if you like.

@m-akinc m-akinc marked this pull request as ready for review May 8, 2024 22:19
packages/blazor-workspace/README.md Outdated Show resolved Hide resolved
packages/blazor-workspace/README.md Show resolved Hide resolved
m-akinc and others added 2 commits May 8, 2024 18:09
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
@m-akinc m-akinc requested a review from rajsite May 8, 2024 23:11
@rajsite rajsite enabled auto-merge (squash) May 9, 2024 18:11
@rajsite rajsite merged commit 43edba8 into main May 9, 2024
11 checks passed
@rajsite rajsite deleted the users/makinc/spright-blazor-docs branch May 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SprightBlazor project
6 participants