Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move angular-workspace to packages folder #2086

Merged
merged 10 commits into from
May 8, 2024
Merged

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented May 8, 2024

Pull Request

🤨 Rationale

Moves /angular-workspace to /packages/angular-workspace and also shrinks paths within the workspace:

  • Moves /projects/ni/nimble-angular to /nimble-angular
  • Moves /projects/ni/spright-angular to /spright-angular
  • Moves /projects/example-client-app to /example-client-app

part of #2084

👩‍💻 Implementation

Straightforward move and path updates. No refactors / other changes.
Marked change as patch to verify publish infra.

🧪 Testing

  • Manually opened all the ng-package.json to verify VSCode detects the schema paths
  • Rely on CI for the rest

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite marked this pull request as ready for review May 8, 2024 21:48
.gitignore Show resolved Hide resolved
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once builds finish let's bypass any remaining owners policies to get this in before any conflicts arise.

@rajsite rajsite merged commit e83c8ba into main May 8, 2024
13 checks passed
@rajsite rajsite deleted the angular-workspace-package branch May 8, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants