Fixed reported bug about console errors #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/nimble-components/src/wafer-map/tests/wafer-map.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
rajsite
approved these changes
May 10, 2024
jattasNI
approved these changes
May 10, 2024
DStavilaNI
approved these changes
May 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Bug 2671736: Wafermap plugin logs unnecessary info to the console.
The bug mentioned above was fixed.
👩💻 Implementation
Resize changes sometimes do not propagate correctly when the component is initialized, so the hover rect gets 'NaN' values for height and width.
Checked the dimensions before setting them.
🧪 Testing
Existing tests are passing.
New test added.
✅ Checklist