-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent box sizing border box #2115
Merged
rajsite
merged 19 commits into
box-sizing-squashed
from
consistent-box-sizing-border-box
Jun 10, 2024
Merged
Consistent box sizing border box #2115
rajsite
merged 19 commits into
box-sizing-squashed
from
consistent-box-sizing-border-box
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
requested review from
jattasNI,
fredvisser and
vivinkrishna-ni
as code owners
June 10, 2024 21:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Switch to using
box-sizing: border-box;
consistently in all our components.π©βπ» Implementation
display
helper when defined which was made consistent in Use display helper consistently for all componentsΒ #2114. This PR leverages that helper to make sure each component sets the elements in the shadow root to usebox-sizing: border-box;
consistently* {}
, the host itself, i.e.:host {}
, and all before and after pseduo-elements so devtools stays clearer, specifically the selector for:host
and the selector for*
are clear in dev tools without the noise of the::before
and::after
selectorsbox-sizing
π§ͺ Testing
Rely on chromatic, explanation of some of the changes:
β Checklist