Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clear select button match design spec #2120

Merged
merged 2 commits into from
May 17, 2024
Merged

Make clear select button match design spec #2120

merged 2 commits into from
May 17, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

The clear button in the nimble-select deviated from the design spec in two ways:

  • The button was 18px by 18px rather than 24px by 24px
  • The icon in the button was nimble-icon-xmark rather than nimble-icon-times

👩‍💻 Implementation

  • Update icon and button size

🧪 Testing

Manually tested in storybook

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, will you buddy this PR for me?

@mollykreis mollykreis marked this pull request as ready for review May 17, 2024 18:52
@rajsite
Copy link
Member

rajsite commented May 17, 2024

bypassing @jattasNI straightforward sizing and icon switch

@rajsite rajsite merged commit c057819 into main May 17, 2024
13 checks passed
@rajsite rajsite deleted the update-clear-select-button branch May 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mollykreis @rajsite @atmgrifter00