Remove extraneous packages from lock file #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you comment on how they were removed? We shouldn't be hand editing the lock file |
m-akinc
commented
May 18, 2024
1 task
|
Closing in favor of #2123 |
rajsite
added a commit
that referenced
this pull request
May 20, 2024
# Pull Request ## 🤨 Rationale It was identified in #2121 that the angular refactor resulted in leftover entries in the lock file. The entries were marked `extraneous` and did not seem to interfere with the build, etc. This PR rebuilds the lock file which cleans out extraneous entries and updates dependencies to package.json supported range latest. ## 👩💻 Implementation ``` git clean -fdx del package-lock.json npm install ``` ## 🧪 Testing Rely on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Found old, extraneous entries in our lock file from before the Angular workspace got moved.
👩💻 Implementation
Removed them.
🧪 Testing
N/A
✅ Checklist