Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLD] Select custom filtering. #2125

Merged
merged 19 commits into from
May 31, 2024
Merged

[HLD] Select custom filtering. #2125

merged 19 commits into from
May 31, 2024

Conversation

atmgrifter00
Copy link
Contributor

Pull Request

🤨 Rationale

👩‍💻 Implementation

This is just a spec update.

atmgrifter00 and others added 3 commits May 21, 2024 10:21
@atmgrifter00 @fredvisser
Update packages/nimble-components/src/select/specs/filterable-select-…
44f608c 
…hld.md

Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
@atmgrifter00 @fredvisser
Update packages/nimble-components/src/select/specs/filterable-select-…
1a1dedf 
…hld.md

Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
@atmgrifter00 @fredvisser
Update packages/nimble-components/src/select/specs/filterable-select-…
7ee8b6e 
…hld.md

Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
@atmgrifter00 atmgrifter00 marked this pull request as ready for review May 21, 2024 15:23
rajsite
rajsite approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed feedback with meyers and think on the same page with all the feedback so marking approve

@atmgrifter00 atmgrifter00 enabled auto-merge (squash) May 31, 2024 15:15
@atmgrifter00 atmgrifter00 merged commit 7f81793 into main May 31, 2024
11 checks passed
@atmgrifter00 atmgrifter00 deleted the select-dynamic-options-HLD branch May 31, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollykreis mollykreis mollykreis approved these changes

@jattasNI jattasNI jattasNI approved these changes

@rajsite rajsite rajsite approved these changes

@fredvisser fredvisser fredvisser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atmgrifter00 @fredvisser @rajsite @jattasNI @mollykreis