Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu button column HLD #2134

Merged
merged 20 commits into from
Jun 12, 2024
Merged

Menu button column HLD #2134

merged 20 commits into from
Jun 12, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

Create HLD for the menu button table column.

👩‍💻 Implementation

N/A

🧪 Testing

N/A

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, can you buddy this PR for me?

mollykreis and others added 3 commits May 30, 2024 09:32
@mollykreis
more updates
72f463b
@mollykreis
Merge branch 'main' into menu-button-column-hld
d086ecb
@mollykreis @atmgrifter00
Update packages/nimble-components/src/table/specs/table-column-specs/…
06139cc 
…table-column-menu-button.md

Co-authored-by: Jonathan Meyer <26874831+atmgrifter00@users.noreply.github.com>
@mollykreis mollykreis marked this pull request as ready for review May 31, 2024 15:37
@mollykreis mollykreis requested a review from rajsite June 12, 2024 16:04
@rajsite rajsite merged commit 50505a9 into main Jun 12, 2024
11 checks passed
@rajsite rajsite deleted the menu-button-column-hld branch June 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanc18 stefanc18 stefanc18 left review comments

@msmithNI msmithNI msmithNI left review comments

@fredvisser fredvisser fredvisser left review comments

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

@jattasNI jattasNI jattasNI approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mollykreis @fredvisser @rajsite @jattasNI @msmithNI @atmgrifter00 @stefanc18