Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request template #2137

Merged
merged 3 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/icon-request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
fredvisser marked this conversation as resolved.
Show resolved Hide resolved
name: 🎨 Icon Design Request
about: Icon design request for a Visual Designer
title: '{icon metaphor} icon request'
labels: 'visual design,triage,icon request'
fredvisser marked this conversation as resolved.
Show resolved Hide resolved
---

<!-- Ensure the title can be understood without the parent item's context, e.g. "Save button icon request" rather than just "new icon" -->

# 🎨 Icon Request

## πŸ“Œ Request Background

<!-- A short description of the request and requester. E.g. Who is the client and how do they expect to use the icon? -->

## πŸ§ͺ Research

<!-- Enumerate the research you've done to identify the correct metaphor and find existing best practices. -->
<!-- Include examples from [Font Awesome](https://fontawesome.com/search), [Noun Project](https://thenounproject.com), and [IconFinder](https://www.iconfinder.com/search) -->

## πŸ₯… Acceptance Criteria

- [ ] Icon reviewed by design team
- [ ] Icon available in [Nimble_Iconography](https://www.figma.com/design/aOmrur2iA2Abc6Pp59NVGV/Nimble_Iconography?node-id=0-1&t=KGtldxWuPIvzgHCo-0) (link)
- [ ] Icon published in Nimble Storybook (link)
2 changes: 2 additions & 0 deletions packages/storybook/src/nimble/icon-base/icons.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import ComponentApisLink from '../../docs/component-apis-link.mdx';

Nimble icons can be slotted into other components or used independently. Each icon is available as a custom element. For example, <Tag name={iconAddTag} openClose/>.

If you need a new icon, please [submit an issue](https://github.com/ni/nimble/issues/new/choose) using the "Icon Design Request" template.

<Canvas of={iconsStories.icons} />

## API
Expand Down
Loading